Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-126] support conversion from String to Map for config #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwin
Copy link
Member

@kwin kwin commented Jun 23, 2020

properties

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like pain. When you have code, you can pass a map, when you are at the command line, it will make the input unreadable. I really fail to see how somenoe will pass Java properties format via a single CLI.

@kwin
Copy link
Member Author

kwin commented Jun 28, 2020

At least for single entries this is good enough also to pass from CLI, e.g. -Daether.connector.http.headers.myrepo="custom-auth-header=customauthvalue". Multiple entries are a pain indeed, but should rarely occur. In any case this is better than before, IMHO. I cannot think of a good solution for multiple entries for CLI or do you have any proposal?

@michael-o
Copy link
Member

michael-o commented Jun 28, 2020

The only thing I can image is that String will contain a local path to a proprties file. But I really would put this issue aside until someone really complains that this does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants